is it illegal to marry someone for their social security benefits

Hi,

No, but you can't be paid someone else's Social Security benefits just because you marry them. You could, however, potentially become eligible for Social Security spousal or survivor benefits based on the work record of your spouse if you meet all of the requirements for benefits (https://www.ssa.gov/planners/retire/applying6.html).

Best, Jerry